Issue 11126 - OOO_STABLE_1_PORTS: cpputools needs patch to recognize dylib
Summary: OOO_STABLE_1_PORTS: cpputools needs patch to recognize dylib
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: OOo 1.0.1
Hardware: Mac Mac OS X, all
: P3 Trivial (vote)
Target Milestone: OOo 1.0.4
Assignee: fa
QA Contact: issues@porting
URL:
Keywords: merge_pending
Depends on:
Blocks:
 
Reported: 2003-02-01 19:53 UTC by sdietrich
Modified: 2007-02-05 03:40 UTC (History)
3 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
cd $SRCROOT/cpputools; patch -p0 < cpputools.unoexe.OOO_STABLE_1_PORTS.020103.patch (689 bytes, patch)
2003-02-01 19:56 UTC, sdietrich 		no flags Details | Diff
cd $SRCROOT/bridges; patch -p0 < bridges.makefiles.OOO_STABLE_1_PORTS.020303.patch (2.07 KB, patch)
2003-02-04 00:43 UTC, sdietrich 		no flags Details | Diff
cd $SRCROOT/cppu; patch -p0 < cppu.data.OOO_STABLE_1_PORTS.020303.patch (567 bytes, patch)
2003-02-04 02:11 UTC, sdietrich 		no flags Details | Diff
cd $SRCROOT/cpputools; patch -p0 < cpputools.unoexe.OOO_STABLE_1_PORTS.021303.patch (498 bytes, patch)
2003-02-14 02:14 UTC, sdietrich 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description sdietrich 2003-02-01 19:53:00 UTC 
The uno executable does not currently recognize "dylib" as a valid library suffix.
Comment 1 sdietrich 2003-02-01 19:56:06 UTC 
Created attachment 4529 [details]
cd $SRCROOT/cpputools; patch -p0 < cpputools.unoexe.OOO_STABLE_1_PORTS.020103.patch
Comment 2 fa 2003-02-01 22:24:26 UTC 
I would advocate not protecting this with #ifdef MACOSX.  I think we should just add the line with the dylib.

Dan
Comment 3 Martin Hollmichel 2003-02-03 09:57:51 UTC 
reassigned to ed.
Comment 4 sdietrich 2003-02-04 00:42:36 UTC 
These bridges makefiles:

bridges/source/java_uno/makefile.mk 
bridges/source/remote/iiop/makefile.mk 
bridges/source/remote/urp/makefile.mk

need to have the "-D" flags removed to avoid changing the "uno_initEnvironment" symbol name.
Comment 5 sdietrich 2003-02-04 00:43:20 UTC 
Created attachment 4559 [details]
cd $SRCROOT/bridges; patch -p0 < bridges.makefiles.OOO_STABLE_1_PORTS.020303.patch
Comment 6 sdietrich 2003-02-04 02:09:55 UTC 
When doing a debug build of cppu on Mac OS X with gcc < 3, we need to define MAX_ALIGNMENT_4 in cppu/source/uno/data.cxx to avoid aborts during alignment tests.
Comment 7 sdietrich 2003-02-04 02:11:14 UTC 
Created attachment 4560 [details]
cd $SRCROOT/cppu; patch -p0 < cppu.data.OOO_STABLE_1_PORTS.020303.patch
Comment 8 khendricks 2003-02-04 16:17:43 UTC 
Hi Dan,  
  
FWIW, I approve all of these patches so that you can commit them.  
 
And yes the unoexe patch does not need an ifdef for MACOSX 
 
Hope this helps.  
  
Kevin
Comment 9 sdietrich 2003-02-14 02:12:13 UTC 
Re-submitting unoexe patch without MACOSX ifdefs. This patch supercedes cpputools.unoexe.OOO_STABLE_1_PORTS.020103.patch.
Comment 10 sdietrich 2003-02-14 02:14:12 UTC 
Created attachment 4722 [details]
cd $SRCROOT/cpputools; patch -p0 < cpputools.unoexe.OOO_STABLE_1_PORTS.021303.patch
Comment 11 fa 2003-03-26 17:18:02 UTC 
cpputools.unoexe.OOO_STABLE_1_PORTS.021303.patch
cppu.data.OOO_STABLE_1_PORTS.020303.patch
bridges.makefiles.OOO_STABLE_1_PORTS.020303.patch

Committed to OOO_STABLE_1_PORTS.  Added keyword merge_pending.

Dan
Comment 12 fa 2003-03-26 17:18:46 UTC 
Taking over...
Comment 13 fa 2003-03-28 04:57:06 UTC 
Changing to started.
Comment 14 fa 2003-08-04 06:09:52 UTC 
Kevin,

Jow many of these patches make sense for 1.1 as well?  at least the cppu.data and the 
cpputools unoexe patches, right?  If so, can you approve?

Dan
Comment 15 khendricks 2003-08-04 16:36:57 UTC 
Hi Dan, 
 
the cpputools.unoexe patch is still needed for OOo 1.1 so approved 
 
the cppu.data patch is okay but not needed since 1.1 is built with gcc 3.3 
 
I am not sure what the bridges.makefiles patch is doing and why? 
 
Do we still need that patch? 
 
Kevin
Comment 16 fa 2003-08-04 17:44:43 UTC 
cpputools.unoexe.OOO_STABLE_1_PORTS.021303.patch applied to 
cws_srx645_ooo11rc3.  Closing issue as fixed.
Comment 17 jjmckenzie 2007-02-05 03:40:33 UTC 
Closing. Branch cannot be updated and is no longer maintained.

James McKenzie