Issue 110801 - package: werror in owriteablestream.cxx (parentheses around '&&' within '||')
Summary: package: werror in owriteablestream.cxx (parentheses around '&&' within '||')
Status: CLOSED FIXED
Alias: None
Product: xml
Classification: Code
Component: code (show other issues)
Version: DEV300m76
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 3.3
Assignee: mikhail.voytenko
QA Contact: issues@xml
URL:
Keywords:
Depends on:
Blocks: 96084
  Show dependency tree
 
Reported: 2010-04-12 11:34 UTC by lohmaier
Modified: 2017-05-20 09:30 UTC (History)
2 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description lohmaier 2010-04-12 11:34:15 UTC 
this is a follow-up to the only-halfway fixed issue 103617 
Only one occurrence of the && clarification parentheses was fixed, not the one 
in the next line.

I wonder how QA could set that other issue to verified :-/

/ooo/build/compile/package/source/xstor/owriteablestream.cxx: In member function 
'virtual com::sun::star::uno::Any OWriteStream::getPropertyValue(const 
rtl::OUString&)':
/ooo/build/compile/package/source/xstor/owriteablestream.cxx:3282: error: 
suggest parentheses around '&&' within '||'
dmake:  Error code 1, while making '../../unxlngi6.pro/slo/owriteablestream.obj'

Patch keeping meaning, silencing the warning

--- package/source/xstor/owriteablestream.cxx       2010-04-10 
01:17:35.214512099 +0200
+++ package/source/xstor/owriteablestream.cxx        2010-04-12 
14:31:04.863492747 +0200
@@ -3279,7 +3279,7 @@
 
        if ( ( ( m_pData->m_nStorageType == PACKAGE_STORAGE || m_pData-
>m_nStorageType == OFOPXML_STORAGE )
                        && aPropertyName.equalsAscii( "MediaType" ) )
-         || m_pData->m_nStorageType == PACKAGE_STORAGE && 
aPropertyName.equalsAscii( "Encrypted" )
+         || ( m_pData->m_nStorageType == PACKAGE_STORAGE && 
aPropertyName.equalsAscii( "Encrypted" ) )
          || aPropertyName.equalsAscii( "Compressed" ) )
        {
                m_pImpl->GetStreamProperties();
Comment 1 mikhail.voytenko 2010-04-12 13:04:35 UTC 
Taking the issue over, since it is my area.
Thank you for the patch. I will integrate it in one of the next OOo3.3 cws's.
Comment 2 jogi 2010-04-14 06:06:31 UTC 
yours as described by yourself
Comment 3 mikhail.voytenko 2010-05-06 14:33:51 UTC 
Integrated in fwk139.
Comment 4 carsten.driesner 2010-06-10 09:16:33 UTC 
cd: Verified on CWS fwk139.