Issue 109444 - Make dev300 buildable on vs8.0 again
Summary: Make dev300 buildable on vs8.0 again
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: code (show other issues)
Version: current
Hardware: Unknown Windows, all
: P3 Trivial (vote)
Target Milestone: OOo 3.3
Assignee: thb
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-19 17:28 UTC by thb
Modified: 2017-05-20 10:23 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description thb 2010-02-19 17:28:19 UTC
Various smallish fixes for $subject
Comment 1 thb 2010-02-19 19:39:39 UTC
Changes committed to cws vs80compat
Comment 2 thb 2010-02-19 22:38:38 UTC
Some notes are due to changeset ea3a9145b615 in cws vs80compat:

 * the namespace lookup things are just annoying
 * as well as the non-working PSTR conversion
 * the conditional operator problem is though clearly a compiler bug,
   what seems to happen here is that the whole expression results in a temporary
   ITextLayout, that happens to have no vtable & thusly crashes subsequently
   as per 5.16 3 item 1, and since both types are reference-compatible, they
   should bind directly and not create any temporaries inbetween. the resulting
   expression type should be ITextLayout&, which again should bind directly to
   the method parameter.
   - anyways, this idiom generates a warning, so the compiler is still safe to
     use in WaE mode.