Issue 108951 - toolkit: new controls Frame, MultiPage + Page
Summary: toolkit: new controls Frame, MultiPage + Page
Status: ACCEPTED
Alias: None
Product: gsl
Classification: Code
Component: code (show other issues)
Version: DEV300m70
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 3.x
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-04 11:58 UTC by noel.power
Modified: 2013-02-01 00:29 UTC (History)
5 users (show)

See Also:
Issue Type: ENHANCEMENT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
test doc (120.50 KB, application/vnd.ms-excel)
2010-02-04 17:36 UTC, noel.power
no flags Details
userform in Excel (16.03 KB, application/vnd.ms-excel)
2010-02-04 17:40 UTC, noel.power
no flags Details
imported userform OOo-m70 (9.14 KB, application/vnd.ms-excel)
2010-02-04 17:41 UTC, noel.power
no flags Details
imported userform cws container-controls (23.23 KB, application/vnd.ms-excel)
2010-02-04 17:41 UTC, noel.power
no flags Details
programatic demo multipage/frame (14.55 KB, application/vnd.oasis.opendocument.spreadsheet)
2010-02-04 17:43 UTC, noel.power
no flags Details
userform in Excel ( correct mime type ) (16.03 KB, image/png)
2010-02-04 17:45 UTC, noel.power
no flags Details
imported userform OOo-m70 ( correct mime type ) (9.14 KB, image/png)
2010-02-04 17:46 UTC, noel.power
no flags Details
imported userform cws container-controls ( correct mime type ) (23.23 KB, image/png)
2010-02-04 17:47 UTC, noel.power
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description noel.power 2010-02-04 11:58:34 UTC
Trying to import Userforms sucks, especially when dealing with container controls  
But why is that a problem? firstly use of container controls is very very
comment ( e.g. Frames ) which are mapped to a GroupBox by the filter don't do
any grouping, additionally a GroupBox isn't really a container which means
  a) a Frame imported as non Visibile  should mean that all containee controls
are also invisible ( but that isn't the case )
  b) the filter has to go to huge trouble ( and doesn't do a good job ) at
trying to fake other container aspect of things like
      1) grouping for radio buttons
      2) position of controls relative to the parent container ( Frame in this
case )
      3) tab order
      4) doesn't do things like realise that a containee control may completely
or partially visible due to being clipped by the boundry of the parent control
etc. etc. etc. If you add in then trying to support vba api of said imported
Userforms then the pain even increases more, but... it gets worse because
   a) Userforms can ( and do ) support multiple levels of containment e.g.
Userform->Frame1->Frame2...
   b) there are *other* containment controls like MultiPage ( and the associated
Pages )

so, I have created some initial implementations for these controls, the
intention is to initially just use these controls for the Userform import only (
but the plan is to of course make them generally available in the future )

I hope we can integrate the cws with these controls implemented as is ( well of
course I hope you both ( Frank & Carsten ) ) will help me stabilise the code
that by cleaning up what's there already and at least ensuring the existing
code's behaviour is unaffected by these changes and behaves as before )
Comment 1 noel.power 2010-02-04 17:36:32 UTC
Created attachment 67617 [details]
test doc
Comment 2 noel.power 2010-02-04 17:39:31 UTC
test document 'NestedContainers.xls' shows the new controls ( filter has been
modified to use the new controls ) ( see issue  108950 also attached to cws
container-controls )

to test, load the document, open the basic IDE, open up the dialogs, press the
test mode ( on/off ) button to raise the dialog ( available from the controls
toolbox in the dialog editor ) - I will attach some images here to show as well
Comment 3 noel.power 2010-02-04 17:40:27 UTC
Created attachment 67618 [details]
userform in Excel
Comment 4 noel.power 2010-02-04 17:41:11 UTC
Created attachment 67619 [details]
imported userform OOo-m70
Comment 5 noel.power 2010-02-04 17:41:48 UTC
Created attachment 67620 [details]
imported userform cws container-controls
Comment 6 noel.power 2010-02-04 17:42:49 UTC
But you can also programatically play with the new controls.... test document to
follow
Comment 7 noel.power 2010-02-04 17:43:44 UTC
Created attachment 67621 [details]
programatic demo multipage/frame
Comment 8 noel.power 2010-02-04 17:45:33 UTC
Created attachment 67622 [details]
userform in Excel ( correct mime type )
Comment 9 noel.power 2010-02-04 17:46:12 UTC
Created attachment 67623 [details]
imported userform OOo-m70 ( correct mime type )
Comment 10 noel.power 2010-02-04 17:47:00 UTC
Created attachment 67624 [details]
imported userform cws container-controls ( correct mime type )
Comment 11 noel.power 2010-03-18 11:36:08 UTC
.
Comment 12 carsten.driesner 2010-03-18 11:45:10 UTC
cd->npower: Noel, I am sure that Frank and I will support as good as possible to
integrate the CWS.
Comment 13 noel.power 2010-03-18 11:55:30 UTC
>cd->npower: Noel, I am sure that Frank and I will support as good as possible to
>integrate the CWS.
I appreciate that :-) the changes here are potentially 'invasive' and I do claim
to be nervous of them, so... some sort of reviewing of the changes ( in toolkit
for sure ) would be very very welcome. But like I said in a recent mail to the
api dev list I understand people are very busy regarding getting the time to get
feedback
"I await feedback from upstream in order to progress things, so when it will be
integrated is uncertain ( and currently most people are busy with feature freeze
etc )"
I include myself in that statement because currently I don't even know if I have
the time to respond to any feedback :-)) (  but hopefully things will calm done
in the next week or 2 )
Comment 14 thorsten.ziehm 2010-09-23 15:30:28 UTC
The corresponding CWS 'container_controls' isn't ready until now. OOo 3.3 is in
showstopper-mode. This issue doesn't look like a stopper for the current
release. I change the target to OOo 3.4 as some other issues in this CWS.