Issue 105784 - vcl: improve selection of fallback font by supplying language hint when none exists
Summary: vcl: improve selection of fallback font by supplying language hint when none ...
Status: ACCEPTED
Alias: None
Product: gsl
Classification: Code
Component: code (show other issues)
Version: DEV300m61
Hardware: All Linux, all
: P3 Trivial (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks: 90439
  Show dependency tree
 
Reported: 2009-10-10 16:37 UTC by caolanm
Modified: 2017-05-20 11:33 UTC (History)
1 user (show)

See Also:
Issue Type: ENHANCEMENT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
patch to do this (8.48 KB, patch)
2009-10-10 16:38 UTC, caolanm 		no flags Details | Diff
update patch for 3.3 (8.48 KB, patch)
2010-07-13 11:12 UTC, caolanm 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description caolanm 2009-10-10 16:37:21 UTC 
Often we have some knowledge of the language that some text is written in when
we are forced to use glyph fallback. This helps fontconfig pick a good font to
use for that text. In some circumstances, e.g. in the UI itself we don't have
any hints to fontconfig basically is forced to pick one at random. What
basically pango does in this circumstance is categorize the script that the text
is written in and assign it a example language written using that script when
asking fontconfig for glyph fallback which gives better results. Patch attached
to do that. 

See https://bugzilla.redhat.com/show_bug.cgi?id=527719 for some screenshots of
the problem at the moment that this solves.
Comment 1 caolanm 2009-10-10 16:38:12 UTC 
Created attachment 65287 [details]
patch to do this
Comment 2 hdu@apache.org 2009-10-14 13:57:17 UTC 
It may be a better idea to have the change in fontconfig itself: if all the codepoints that fc is requested to 
resolve are typical for script XXX then fc should prefer a font designed for XXX.
Comment 3 philipp.lohmann 2009-11-05 15:47:52 UTC 
@hdu: so go or no go ? meaning integrate or change to enhancment ?
Comment 4 hdu@apache.org 2009-11-06 08:21:51 UTC 
We already provide the language to fontconfig if we know the language attribute of the text. If we do not 
know the language one can only guess based on the missing codepoints. That is just what the patch does.

It is a nice idea for libfontconfig where it belongs. Not doing it there works against (or at least around) FC 
by pretending to know something which we don't know.

Now for the UI issue itself: the selected UI language is known and should be provided.
Comment 5 caolanm 2010-07-13 11:12:18 UTC 
Created attachment 70594 [details]
update patch for 3.3
Comment 6 Marcus 2017-05-20 11:33:17 UTC 
Reset assigne to the default "issues@openoffice.apache.org".