Issue 105734 - sw: && || in SwXMLSectionList
Summary: sw: && || in SwXMLSectionList
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: code (show other issues)
Version: DEV300m61
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: Oliver Specht
QA Contact: issues@sw
URL:
Keywords:
Depends on:
Blocks: 96084
  Show dependency tree
 
Reported: 2009-10-08 16:05 UTC by caolanm
Modified: 2013-08-07 14:44 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
like so (1.51 KB, patch)
2009-10-08 16:06 UTC, caolanm 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description caolanm 2009-10-08 16:05:07 UTC 
source/core/swg/SwXMLSectionList.cxx has some && || code which might be
ambiguous to a human and recent gccs warn about it. Attached is a patch which
brackets it the way the compiler sees it, i.e. no change in logic, assuming that
the code is as intended.
Comment 1 caolanm 2009-10-08 16:06:30 UTC 
Created attachment 65249 [details]
like so
Comment 2 andreas.martens 2009-10-09 07:43:06 UTC 
ama->os: Please have a look.
Comment 3 Oliver Specht 2010-01-08 14:28:53 UTC 
Patch applied in cws os140
Comment 4 Oliver Specht 2010-06-08 07:47:22 UTC 
set to verified
Comment 5 caolanm 2010-07-16 10:27:44 UTC 
closing, integrated DEV300m83