Issue 104370 - oox: suspicious || &&
Summary: oox: suspicious || &&
Status: CLOSED FIXED
Alias: None
Product: xml
Classification: Code
Component: code (show other issues)
Version: DEV300m54
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 3.2
Assignee: daniel.rentz
QA Contact: issues@xml
URL:
Keywords:
Depends on:
Blocks: 96084
  Show dependency tree
 
Reported: 2009-08-20 17:29 UTC by caolanm
Modified: 2009-09-22 09:11 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
like so (720 bytes, patch)
2009-08-20 17:30 UTC, caolanm 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description caolanm 2009-08-20 17:29:47 UTC 
The logic in oox/source/vml/vmlshape.cxx for an empty shape looks suspicious,
i.e currently it binds as...

if (Width > 0) || ((Height > 0) && Shape.is())

I suspect it should be

if ((Width > 0) || (Height > 0)) && Shape.is())
Comment 1 caolanm 2009-08-20 17:30:05 UTC 
Created attachment 64272 [details]
like so
Comment 2 daniel.rentz 2009-08-20 18:51:54 UTC 
thanks for catching, fixed in DEV300/dr72
Comment 3 daniel.rentz 2009-08-20 18:53:45 UTC 
target
Comment 4 daniel.rentz 2009-08-25 10:20:33 UTC 
verified in CWS source code
Comment 5 daniel.rentz 2009-09-22 09:11:23 UTC 
closed