Issue 103305 - sw: X & Y | Z, did ve really mean to say that
Summary: sw: X & Y | Z, did ve really mean to say that
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: code (show other issues)
Version: DEV300m51
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: michael.ruess
QA Contact: issues@sw
URL:
Keywords:
Depends on:
Blocks: 96084
  Show dependency tree
 
Reported: 2009-07-03 06:17 UTC by dtardon
Modified: 2013-08-07 14:44 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
make the current meaning explicit (779 bytes, patch)
2009-07-03 06:18 UTC, dtardon 		no flags Details | Diff
fix the (potential) bug (777 bytes, patch)
2009-07-03 06:19 UTC, dtardon 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description dtardon 2009-07-03 06:17:39 UTC 
There is an if in sw/source/docvw/edtwin.cxx:1405 whose subexpression is

(nLclSelectionType & nsSelectionType::SEL_DRW|nsSelectionType::SEL_DRW_FORM)

According to operator precedence, this is parsed by compiler as

( ( nLclSelectionType & nsSelectionType::SEL_DRW ) | nsSelectionType::SEL_DRW_FORM )

, thus it will always evaluate to true in boolean context. Is that what was meant?
Comment 1 dtardon 2009-07-03 06:18:24 UTC 
Created attachment 63342 [details]
make the current meaning explicit
Comment 2 dtardon 2009-07-03 06:19:07 UTC 
Created attachment 63343 [details]
fix the (potential) bug
Comment 3 andreas.martens 2009-07-07 14:42:20 UTC 
ama->os: sounds reasonable, doesn't it?
Comment 4 Oliver Specht 2009-07-07 15:07:46 UTC 
Fixed in cws os133. 
The key combinations shift+ctrl+a activates the anchor of objects. This makes it
possible to move the anchor with the cursor keys.
Additionally the selection of graphic anchors is also possible now. I don't know
why it was only enabled for form controls, drawings and text frames.
Comment 5 Oliver Specht 2009-08-07 12:24:07 UTC 
target set
reassigned for verification
Comment 6 michael.ruess 2009-08-14 10:27:43 UTC 
Verified in CWS os133.
Comment 7 michael.ruess 2009-10-02 10:30:47 UTC 
Checked in DEV300m60.