Issue 103304 - sw: condition always true
Summary: sw: condition always true
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: code (show other issues)
Version: DEV300m51
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: mst.ooo
QA Contact: issues@sw
URL:
Keywords:
Depends on:
Blocks: 96084
  Show dependency tree
 
Reported: 2009-07-03 05:29 UTC by dtardon
Modified: 2013-08-07 14:44 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
patch to fix it (711 bytes, patch)
2009-07-03 05:30 UTC, dtardon 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description dtardon 2009-07-03 05:29:23 UTC 
There is a highly suspicious if condition always evaluating to true in
sw/source/core/text/txtfrm.cxx:1043 :

if( ! nTmp || RES_TXTATR_CHARFMT == nTmp || RES_TXTATR_AUTOFMT ||

I suspect it really should be

if( ! nTmp || RES_TXTATR_CHARFMT == nTmp || RES_TXTATR_AUTOFMT == nTmp ||
Comment 1 dtardon 2009-07-03 05:30:16 UTC 
Created attachment 63341 [details]
patch to fix it
Comment 2 andreas.martens 2009-07-07 10:31:13 UTC 
ama->ms: Sounds reasonable, doesn't it?
Comment 3 mst.ooo 2009-07-07 11:11:57 UTC 
quite reasonable; thus fixed in cws sw32bf02 (revision 273788)
thanks to dtardon for the patch!
Comment 4 mst.ooo 2009-08-21 14:34:16 UTC 
.
Comment 5 mst.ooo 2009-09-09 11:02:08 UTC 
.