Issue 102694 - Floaters (Styles and Formatting, Navigator) doesn't get the focus on opening
Summary: Floaters (Styles and Formatting, Navigator) doesn't get the focus on opening
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: ui (show other issues)
Version: OOo 3.0
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 3.3
Assignee: eric.savary
QA Contact: issues@framework
URL:
Keywords: accessibility
: 111417 (view as issue list)
Depends on:
Blocks:
 
Reported: 2009-06-12 07:36 UTC by hammera
Modified: 2010-06-23 12:17 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description hammera 2009-06-12 07:36:58 UTC
I would like format the document with heading levels with Openoffice.org Writer.
When I select format main menu and style and formats menu item, first displayed
the required dialog, but does'nt focused the window.
Not problem, I pressed alt+f6 key and choosed for example the required heading
level 2 style.
When need again the required task, I try choose again the format main menu and
style and formats menu item, but nothing happen. I see this menu item is a check
menu item with Openoffice.org 3.0, the second choose the checked state was
removed, so, need repeat this steps when need the required dialog again, but the
displayed dialog again not focused.
I wrote my problem with Orca mailing list, and Willie Walker (Orca developer)
answer this:
"This seems to be a general issue with OpenOffice -- it's easily reproduced even
if Orca is not running.  Please file a bug at
http://qa.openoffice.org/issue_handling/submission_gateway.html and add
'williewalker' to the CC list?

> My question: have any useful keystroke to display the format and styles dialog
anytime, independent the style and formats menu item checked state?

Shift+F6 seems to help move focus to the dialog.  There's also an F11 action
that's shown on the menu item that seems to act as an accelerator/shortcut if
the main window has focus.  I'm noticing a couple issues, however:

1) The F11 action on the menu item is not exposed to us via the AT-SPI (sigh)

2) Focus seems to disappear somewhere in the Styles and Formatting dialog.  That
is, I can give it focus, but I cannot seem to arrow up and down the entries. 
The only way I can force focus to appear is if I move the mouse into the dialog
-- I don't have to click, I just have to move it there.  It's as though OOo
chose to implement that "pointer gives focus" window manager behavior that I
detest so mightily.

Both of these problem are independent of whether Orca is running or not."
Not only this dialog producing this unfocusable problem, for example when I
write document with OO Writer, not save and press Alt+f4 key, the displayed
dialog was not focusing anytime. Sometime yes, some time no.

Possible fix this?

Attila
Comment 1 eric.savary 2009-06-12 11:51:10 UTC
Reassigning
Comment 2 eric.savary 2009-06-12 14:49:22 UTC
.
Comment 3 eric.savary 2009-06-15 15:47:25 UTC
There are 2 problems here:

1. Styles and Formatting does not get the focus when called.

AFAIK this works as designed.
Such floaters like the Navigator don't get the focus because they act like
toolbars. Thes show a functionality but don't get the focus to let user work
further in the document.

2, Travelling with F6 into the Styles and Formatting floater sets the focus nowhere

I will file a second issue for 2) and keep this issue as 1).
But 1) may be flagged as WONTFIX.
Comment 4 eric.savary 2009-06-15 15:55:18 UTC
My statement to 1): works like this on Gnome and KDE.
On Windows and MAC OSX, the focus is set in the floater when opening.
Comment 5 eric.savary 2009-06-15 16:03:02 UTC
2) is now issue 102803.
Comment 6 ab 2009-06-16 14:10:35 UTC
ab->pl: accessibility can only reflect what's actually happening.
Please have a look at the platform dependent behavior.
Comment 7 philipp.lohmann 2009-06-16 16:09:20 UTC
Historically navigator and stylist are not supposed to get the focus when
opening. If that should be changed, simply calling Show without the no focus
change paramter should do the trick.
Comment 8 malte_timmermann 2009-12-07 11:47:07 UTC
Not setting the focus in bad for UX in general, and AT wouldn't announce the new
dialog => 3.3
Comment 9 malte_timmermann 2010-01-12 14:05:57 UTC
mt: floater needs to get the focus, otherwise AT has no reason to announce the
window.

Floater already get the focus on Windows, but not on GNOME. Don't know if it
works on Mac (please check after fixing on GNOME).
Comment 10 malte_timmermann 2010-01-28 12:10:43 UTC
I will try to take over...
Comment 11 malte_timmermann 2010-02-10 11:30:43 UTC
Fixed in cws mtaccfixes
Comment 12 malte_timmermann 2010-03-05 16:39:47 UTC
After a CWS rebase, the issue occurs again.
Comment 13 malte_timmermann 2010-03-05 16:42:29 UTC
Philipp - since I will be on vacation next week, can you please have a look?

Thanks! :)
Comment 14 philipp.lohmann 2010-03-31 13:19:59 UTC
more hacking for metacity :-(

fixed in CWS vcl111, changeset at

http://hg.services.openoffice.org/hg/cws/vcl111/rev/6bcea0021bd1

@cmc:

This seems to work now so that Navigator (or Stylist or ...) do
- not get the focus when opening a new document and navigator opens because of that
- does get the focus when the navigator is user activated (as in e.g. pressing F5)

This is IMHO the wanted behavior.

Any opinion on this ?

@mt: works on the mac as described without modifications
Comment 15 philipp.lohmann 2010-05-06 12:33:08 UTC
*** Issue 111417 has been marked as a duplicate of this issue. ***
Comment 16 philipp.lohmann 2010-05-21 14:10:53 UTC
please verify in CWS vcl111
Comment 17 eric.savary 2010-06-10 09:36:53 UTC
Verified in CWS vcl111 for GTK

F'up task for KDE for which it still doesn't work.
Comment 18 eric.savary 2010-06-10 09:57:42 UTC
For KDE, see issue 112270.
Comment 19 malte_timmermann 2010-06-23 12:17:48 UTC
Closing accessibility issues which have been fixed, verified and integrated...