Issue 101074 - sd: fillItemSet is nothrow, but this .pptx causes exception which is neither caught nor can pass through -> crash
Summary: sd: fillItemSet is nothrow, but this .pptx causes exception which is neither ...
Status: CLOSED DUPLICATE of issue 101563
Alias: None
Product: Draw
Classification: Application
Component: code (show other issues)
Version: OOO310m9
Hardware: All Linux, all
: P3 Trivial (vote)
Target Milestone: ---
Assignee: sven.jacobi
QA Contact: issues@graphics
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-14 11:40 UTC by caolanm
Modified: 2009-05-18 15:29 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
one solution (970 bytes, patch)
2009-04-14 11:41 UTC, caolanm
no flags Details | Diff
sample .pptx (4.51 MB, application/vnd.ms-powerpoint)
2009-04-14 11:42 UTC, caolanm
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description caolanm 2009-04-14 11:40:40 UTC
void SdUnoPageBackground::fillItemSet( SdDrawDocument* pDoc, SfxItemSet& rSet )
throw()

so, don't throw anything.  but, setPropertyValue( aPropertyName, *pAny ) can
throw, and does in the example .pptx
so I get a crash with...

"
terminate called after throwing an instance of
'com::sun::star::lang::IllegalArgumentException'
Program received signal SIGABRT, Aborted.
"

fillItemSet needs to either be allowed to throw, or catch all possible
exceptions internally. 
patch to allow throwing through fillItemSet attached.

(though I guess there's probably a second bug wrt. why something got thrown in
the first place for the background property)
Comment 1 caolanm 2009-04-14 11:41:03 UTC
Created attachment 61556 [details]
one solution
Comment 2 caolanm 2009-04-14 11:42:27 UTC
Created attachment 61557 [details]
sample .pptx
Comment 3 wolframgarten 2009-04-14 12:02:44 UTC
Reassigned. Please handle.
Comment 4 sven.jacobi 2009-05-18 15:24:00 UTC
This issue already has been fixed with i101564 in cws[impress171]

*** This issue has been marked as a duplicate of 101563 ***
Comment 5 caolanm 2009-05-18 15:29:52 UTC
close as dup