Issue 101063 - WaE in svtools
Summary: WaE in svtools
Status: CLOSED FIXED
Alias: None
Product: utilities
Classification: Unclassified
Component: code (show other issues)
Version: DEV300m43
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 3.2
Assignee: philipp.lohmann
QA Contact: Unknown
URL:
Keywords:
Depends on:
Blocks: 96084
  Show dependency tree
 
Reported: 2009-04-14 08:56 UTC by philipp.lohmann
Modified: 2009-06-13 15:21 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
patch (3.16 KB, image/tiff)
2009-04-14 08:56 UTC, philipp.lohmann 		no flags Details
patch with correct mimetype (3.16 KB, patch)
2009-04-14 08:57 UTC, philipp.lohmann 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description philipp.lohmann 2009-04-14 08:56:22 UTC 
With gcc 4.3.2 there are some warnings in svtools' file dialog implementation.
The attached patch fixes them. Please review.
Comment 1 philipp.lohmann 2009-04-14 08:56:57 UTC 
Created attachment 61546 [details]
patch
Comment 2 philipp.lohmann 2009-04-14 08:57:31 UTC 
Created attachment 61547 [details]
patch with correct mimetype
Comment 3 Frank Schönheit 2009-04-14 11:13:02 UTC 
looks reasonable, though not all of the code is mine.

In line 378 of inettbc.cxx, the "> 1" should in fact be a "> 2", I suppose ...?
Comment 4 Frank Schönheit 2009-04-14 11:14:34 UTC 
fs->pl: reviewed :), see above. I suppose you have some gcc-4.3.2-CWS at hand?
Comment 5 philipp.lohmann 2009-04-20 22:17:40 UTC 
committed in CWS vcl101 (with the aforementioned change)
Comment 6 philipp.lohmann 2009-04-22 10:19:33 UTC 
target
Comment 7 philipp.lohmann 2009-04-28 12:48:23 UTC 
verfied in CWS vcl101
Comment 8 caolanm 2009-06-13 15:21:30 UTC 
seen master