Issue 101062 - WaE in sfx and uui
Summary: WaE in sfx and uui
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: OOo 1.0.0
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 3.2
Assignee: dtardon
QA Contact: issues@framework
URL:
Keywords:
Depends on:
Blocks: 96084
  Show dependency tree
 
Reported: 2009-04-14 08:52 UTC by philipp.lohmann
Modified: 2009-05-01 20:33 UTC (History)
3 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
patch (11.98 KB, patch)
2009-04-14 08:53 UTC, philipp.lohmann 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description philipp.lohmann 2009-04-14 08:52:54 UTC 
with gcc 4.3.2 there are some warnings in sfx2 and uui. The attached patch fixes
them.
Comment 1 philipp.lohmann 2009-04-14 08:53:22 UTC 
Created attachment 61545 [details]
patch
Comment 2 carsten.driesner 2009-04-14 10:09:34 UTC 
cd: Could you please have a look, too.
Comment 3 carsten.driesner 2009-04-14 10:10:09 UTC 
cd: Set target.
Comment 4 carsten.driesner 2009-04-16 12:06:57 UTC 
cd->cmc: You already attached a warning free patch for sfx2 at issue 101127.
Could you please look at the patch from pl. I can see some differences between
both patches. May be this is related that different gcc versions were used?
Comment 5 caolanm 2009-04-16 12:38:50 UTC 
cmc->cd: Its actually exactly the same (ignoring whitespace and different order
of files) except
a) this patch here includes an extra fix in workwin.cxx which has already been
merged to DEV300_m47
b) this patch fixes an additional warning in uui

want me to take this and add in the extra uui bit into my existing workspace ?,
I can always revert my own sfx2 changes if you'd prefer to do it yourself.
Comment 6 carsten.driesner 2009-04-16 13:12:06 UTC 
cd->cmc: Yes, please take over. You better know what has been done so far and it
avoids conflicts.
Comment 7 caolanm 2009-04-16 13:42:50 UTC 
taking
Comment 8 caolanm 2009-04-16 13:48:34 UTC 
done in cmcfixes57
Comment 9 caolanm 2009-04-16 13:52:33 UTC 
please verify the extra uui bit in cmcfixes57
Comment 10 dtardon 2009-04-17 07:39:39 UTC 
verified in cmcfixes57
Comment 11 caolanm 2009-05-01 20:33:19 UTC 
integrated DEV300_m47