Issue 100722 - Compressed files do not need to be compressed again in Storage
Summary: Compressed files do not need to be compressed again in Storage
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: save-export (show other issues)
Version: DEV300m45
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: michael.ruess
QA Contact: issues@sw
URL: http://wiki.services.openoffice.org/w...
Keywords: performance
: 100719 100720 100721 (view as issue list)
Depends on:
Blocks:
 
Reported: 2009-03-31 15:40 UTC by bjoern.michaelsen
Modified: 2013-08-07 14:44 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description bjoern.michaelsen 2009-03-31 15:40:52 UTC 
Compressed files (like for example jpeg images) are currently compressed agained
when stored in an ODF file.
These file do not compress well or at all so little is gained by compressing
them again. Because these files are often a major contribution to the whole data
compressed in a ODF file, they are a major contribution to the total save time.

To improve the save performance of the OOo writer it would be nice to store
these files uncompressed.
Comment 1 bjoern.michaelsen 2009-03-31 15:57:00 UTC 
*** Issue 100721 has been marked as a duplicate of this issue. ***
Comment 2 bjoern.michaelsen 2009-03-31 15:57:43 UTC 
*** Issue 100720 has been marked as a duplicate of this issue. ***
Comment 3 bjoern.michaelsen 2009-03-31 15:58:13 UTC 
*** Issue 100719 has been marked as a duplicate of this issue. ***
Comment 4 Oliver Specht 2009-04-03 09:26:40 UTC 
Target changed to 3.2
Comment 5 mikhail.voytenko 2009-04-03 12:01:50 UTC 
The default behavior of the storage implementation is changed in the way that
the streams of the known compressed types are no more compressed by default.

They are still compressed if it is explicitly requested, or in case the stream
was already compressed and was copied to the storage. In the last case there is
no performance problem usually, since the stream is already compressed and the
binary copying takes place internally.
Comment 6 mikhail.voytenko 2009-04-03 12:10:01 UTC 
Currently the following formats are set as known compressed formats JPG, PNG,
GIF, as these formats are the most common case.

In case this list should be extended, please submit a standalone issue with the
list. This issue was more about having this mechanics in storage implementation.
Comment 7 mikhail.voytenko 2009-05-15 10:57:05 UTC 
mav->mru: Please verify the issue. To do so you can just create a new document,
insert images of the mentioned formats, store it and investigate the result file
with a zip tool ( usually they provide information whether a stream is
compressed or not ).
Comment 8 michael.ruess 2009-05-19 13:55:06 UTC 
Verified in CWS os128.
Comment 9 michael.ruess 2009-07-03 11:50:29 UTC 
checked in DEV300m51.