Issue 100683 - Handling relative URLs needs to be improved
Summary: Handling relative URLs needs to be improved
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: DEV300m41
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 3.2
Assignee: michael.ruess
QA Contact: issues@framework
URL:
Keywords: oooqa, performance
Depends on:
Blocks:
 
Reported: 2009-03-30 15:22 UTC by Oliver Specht
Modified: 2009-07-03 12:23 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
patch reduces calls to URIHelper::simpleNormalizedMakeRelative() (3.09 KB, patch)
2009-03-31 06:58 UTC, Oliver Specht 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Oliver Specht 2009-03-30 15:22:29 UTC 
URLs are made relative and are checked for case sensitive pathes in xmloff while
saving documents. This is done for all supported URL protocols no matter if the
location to store the documents matches their protocol. 
For example to save the ODF 1.1 specification document (
http://docs.oasis-open.org/office/v1.1/OS/OpenDocument-v1.1.odt ) about 20% of
time to save is consumed in trying to make the contained http URLs relative. 

The handling of case sensitive file names needs to be checked also.
Comment 1 Oliver Specht 2009-03-31 06:58:07 UTC 
Created attachment 61298 [details]
patch reduces calls to URIHelper::simpleNormalizedMakeRelative()
Comment 2 Oliver Specht 2009-03-31 07:12:17 UTC 
Target set

result for odf spec, time values in µs: 

Class::Function                   Calls Self Time Total Time

SvXMLExport::GetRelativeReference 1.017   27.366   5.646.599
SvXMLExport::GetRelativeReference 1.017   25.119     33.607

Integrated in cws os128
Handling of file URLs needs additional investigation
Comment 3 Oliver Specht 2009-04-05 15:48:37 UTC 
.
Comment 4 Oliver Specht 2009-05-15 09:03:23 UTC 
Reassigned for verification
Comment 5 michael.ruess 2009-05-19 13:23:46 UTC 
Verified in CWS os128. Speed for saving the mentioned document increased heavily.
Comment 6 michael.ruess 2009-07-03 12:23:39 UTC 
Checked in DEV300m51.