Issue 100487 - sw: suspicious indentation and braces in if else
Summary: sw: suspicious indentation and braces in if else
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: code (show other issues)
Version: DEV300m44
Hardware: All Linux, all
: P3 Trivial (vote)
Target Milestone: ---
Assignee: Oliver Specht
QA Contact: issues@sw
URL:
Keywords:
Depends on:
Blocks: 96084
  Show dependency tree
 
Reported: 2009-03-23 17:50 UTC by caolanm
Modified: 2013-08-07 14:44 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
changes logic, but might be what was meant (1.06 KB, patch)
2009-03-23 17:50 UTC, caolanm 		no flags Details | Diff
keeps current logic, but fixes indentation (855 bytes, patch)
2009-03-23 17:51 UTC, caolanm 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description caolanm 2009-03-23 17:50:30 UTC 
in sw/source/core/fields/cellfml.cxx we have some suspicious indentation around
a bare trailing if else

Attached is a patch that changes the current logic, but matches the indentation.
And attached is a patch that keeps the current logic, one of them is right :-)
Comment 1 caolanm 2009-03-23 17:50:59 UTC 
Created attachment 61123 [details]
changes logic, but might be what was meant
Comment 2 caolanm 2009-03-23 17:51:28 UTC 
Created attachment 61124 [details]
keeps current logic, but fixes indentation
Comment 3 Mathias_Bauer 2009-04-14 13:28:14 UTC 
Oliver, please take over
Comment 4 Oliver Specht 2009-04-16 09:01:21 UTC 
->cmc: The second patch is about a different problem (tblrwcl.cxx)

Fixed in cws os130
Comment 5 Oliver Specht 2009-05-19 13:27:12 UTC 
Set to verified. I have no use case that shows the diffent behavior.
Comment 6 caolanm 2010-07-16 10:26:03 UTC 
closing, integrated DEV300m52