Issue 100480 - xmloff: ambiguous && and ||
Summary: xmloff: ambiguous && and ||
Status: CLOSED FIXED
Alias: None
Product: xml
Classification: Code
Component: code (show other issues)
Version: DEV300m44
Hardware: All Linux, all
: P3 Trivial (vote)
Target Milestone: OOo 3.2
Assignee: Oliver-Rainer Wittmann
QA Contact: issues@xml
URL:
Keywords:
Depends on:
Blocks: 96084
  Show dependency tree
 
Reported: 2009-03-23 14:09 UTC by caolanm
Modified: 2010-02-15 09:54 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
silences warnings, keeps current logic (843 bytes, patch)
2009-03-23 14:11 UTC, caolanm 		no flags Details | Diff
changes current behaviour, but might be what was intended (844 bytes, patch)
2009-03-23 14:19 UTC, caolanm 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description caolanm 2009-03-23 14:09:53 UTC 
in source/text/XMLTextFrameContext.cxx
we have some && and || which are potentially ambiguous

attached is version1 which keeps the existing logic, but adds
explicit brackets.

also attached is version2, which changes the logic, but is
possibly what was originally intended.

Which is the desired outcome ?
Comment 1 caolanm 2009-03-23 14:11:50 UTC 
Created attachment 61116 [details]
silences warnings, keeps current logic
Comment 2 caolanm 2009-03-23 14:20:17 UTC 
Created attachment 61117 [details]
changes current behaviour, but might be what was intended
Comment 3 Mathias_Bauer 2009-04-14 13:26:37 UTC 
Target 3.2
Comment 4 Mathias_Bauer 2009-06-03 09:59:11 UTC 
Oliver, please take over
Comment 5 Oliver-Rainer Wittmann 2009-06-25 07:28:14 UTC 
Yes, I will take care of this one - added to cws sw32bf02
Comment 6 Oliver-Rainer Wittmann 2009-08-17 13:05:37 UTC 
At least I found the time to integrate the patch into a corresponding cws -
namely sw32bf02.

Applied second version of the patch (as CMC stated already that is what was
intended) - change file:
/xmloff/source/text/XMLTextFrameContext.cxx, rev. 275049
Comment 7 mst.ooo 2009-08-21 15:31:54 UTC 
verified
Comment 8 Oliver-Rainer Wittmann 2010-02-15 09:54:43 UTC 
closing