Issue 100225 - ServiceDecl needs visibility markup
Summary: ServiceDecl needs visibility markup
Status: CLOSED FIXED
Alias: None
Product: udk
Classification: Code
Component: code (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 3.2
Assignee: thb
QA Contact: issues@udk
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-16 10:18 UTC by thb
Modified: 2009-05-01 20:31 UTC (History)
2 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Proposed fix (1.91 KB, patch)
2009-03-16 10:19 UTC, thb 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description thb 2009-03-16 10:18:33 UTC 
After the bulk addition of VISIBILITY_HIDDEN=TRUE to components,
comphelper::ServiceDecl's c funcs need visibility markup now.
Comment 1 thb 2009-03-16 10:19:58 UTC 
Created attachment 60945 [details]
Proposed fix
Comment 2 Stephan Bergmann 2009-03-16 10:31:52 UTC 
svn log -c 182254
svn://svn.services.openoffice.org/ooo/trunk/comphelper/inc/comphelper/servicedecl.hxx
------------------------------------------------------------------------
r182254 | kz | 2006-12-13 17:10:15 +0100 (Wed, 13 Dec 2006) | 4 lines

INTEGRATION: CWS presfixes09 (1.3.40); FILE MERGED
2006/09/18 12:53:30 thb 1.3.40.2: #i10000# Made code compile warning-free
2006/09/18 12:44:36 thb 1.3.40.1: Added a few macros for the C export boilerplate

------------------------------------------------------------------------
Comment 3 thb 2009-03-16 12:59:29 UTC 
@sb: and? your changes broke it. in case you wanted to politely suggest I should
undertake the arduous endeavour of creating a CWS and upstream this myself
please say so (of course, offering an already opened CWS alongside would be
greatly appreciated). ;)
Comment 4 Stephan Bergmann 2009-03-16 13:46:39 UTC 
@thb:  What broke exactly?  I am not aware of any breaks, and you did not state any.
Comment 5 thb 2009-03-16 23:18:18 UTC 
@sb: everything that uses ServiceDecl's component macros and has
VISIBILITY_HIDDEN=TRUE in the makefile. Which, incidentally, happens to be the
null set currently, but needlessly so. ;)
Comment 6 caolanm 2009-03-30 09:47:35 UTC 
I can take this if you want as I ran into the same problem
Comment 7 thb 2009-03-30 15:39:09 UTC 
@cmc: thx, much appreciated!
Comment 8 caolanm 2009-04-15 15:55:02 UTC 
done in cmcfixes57
Comment 9 caolanm 2009-04-15 16:23:02 UTC 
.
Comment 10 caolanm 2009-04-16 11:13:50 UTC 
please verify in cmcfixes57
Comment 11 thb 2009-04-16 11:50:44 UTC 
thx for taking; verified in CWS.
Comment 12 caolanm 2009-05-01 20:31:42 UTC 
integrated DEV300_m47