Issue 2455

Summary: Order in which libraries are linked produces unresolved symbols
Product: porting Reporter: Unknown <non-migrated>
Component: codeAssignee: nickb
Status: CLOSED WONT_FIX QA Contact: issues@porting <issues>
Severity: Trivial    
Priority: P3 CC: issues, nickb
Version: 641   
Target Milestone: AOO PleaseHelp   
Hardware: SGI   
OS: IRIX   
Issue Type: DEFECT Latest Confirmation in: ---
Developer Difficulty: ---
Attachments:
Description Flags
setup2/source/custom/moffice/makefile.mk - preferable patch
none
setup2/source/custom/moffice/makefile.mk - less preferable patch
none
desktop/source/offwrp/makefile.mk - libraries reordered
none
offmgr/util/makefile.mk - reorder libraries
none
sc/util/makefile.mk - reorder libraries
none
sd/util/makefile.mk - reorder libraries
none
svx/util/makefile.mk - reorder libraries
none
patch for sw/util/makefile.mk none

Description Unknown 2001-12-06 02:53:11 UTC
setup2/source/custom/moffice/makefile.mk needs to link mowos.o before SALLIB on 
IRIX, otherwise will produce unresolved symbols when linking, as IRIX is 
specific about the order in which files are linked.
Comment 1 Unknown 2001-12-06 04:07:28 UTC
Created attachment 769 [details]
setup2/source/custom/moffice/makefile.mk - preferable patch
Comment 2 Unknown 2001-12-06 04:09:10 UTC
Created attachment 770 [details]
setup2/source/custom/moffice/makefile.mk - less preferable patch
Comment 3 Unknown 2001-12-06 04:13:28 UTC
the difference b/w the 2 patches is that the second uses a few 
conditionals to make sure the makefile is uneffected for other 
platforms.
The first has been tested on Linux and made absolutely no difference, 
and is the preferable choice, as it is much cleaner.
Comment 4 Unknown 2001-12-07 01:13:27 UTC
In IRIX, the order in which libraries and objects files are linked is 
very important. If linked in an incorrect order, the linker can 
report unresolved symbols. For this reason some makefiles need to 
changed so that libraries linked in are re-ordered to resolve this 
problem. AFAIK this will not make any difference to any other unix 
platforms, (Definately not LINUX, as I have tested the patches to 
follow on Linux).
Comment 5 Unknown 2001-12-07 01:43:02 UTC
Created attachment 772 [details]
desktop/source/offwrp/makefile.mk - libraries reordered
Comment 6 Unknown 2001-12-07 01:43:43 UTC
This patch has been tested on Linux and worked perfectly fine
Comment 7 Unknown 2001-12-07 02:06:38 UTC
Created attachment 773 [details]
offmgr/util/makefile.mk - reorder libraries
Comment 8 Unknown 2001-12-07 02:08:12 UTC
patch for offmgr/util/makefile.mk has been tested on Linux and has 
zero impact. Should have no impact on no other platform either.
Comment 9 Unknown 2001-12-07 03:45:35 UTC
Created attachment 777 [details]
sc/util/makefile.mk - reorder libraries
Comment 10 Unknown 2001-12-07 03:48:18 UTC
The patch for sc/util/makefile.mk was tested on Linux and had zero 
impact. Should not have an impact on any other platforms either
Comment 11 Unknown 2001-12-07 05:24:31 UTC
Created attachment 778 [details]
sd/util/makefile.mk - reorder libraries
Comment 12 Unknown 2001-12-07 05:25:32 UTC
The patch for sd/util/makefile.mk has been tested in Linux and had 
zero impact. Should not have any impact on any other platforms either.
Comment 13 Unknown 2001-12-07 06:38:12 UTC
Created attachment 779 [details]
svx/util/makefile.mk - reorder libraries
Comment 14 Unknown 2001-12-07 06:39:40 UTC
The patch for svx/util/makefile.mk has been tested with Linux and had 
zero impact. Should have no impact on no other platform either.
Comment 15 sander_traveling 2002-03-11 20:57:37 UTC
Commited in:

setup2/source/custom/moffice/makefile.mk rev 1.7.2.1 
desktop/source/offwrp/makefile.mk rev 1.2.8.1
offmgr/util/makefile.mk rev 1.17.2.1
sc/util/makefile.mk rev  1.12.2.1
sd/util/makefile.mk rev 1.14.2.1
svx/util/makefile.mk rev  1.16.2.2

these are all in OOO_STABLE_1
Comment 16 Unknown 2003-03-19 05:17:50 UTC
Reopening issue. There is another case in the sw module
Comment 17 Unknown 2003-03-19 05:19:48 UTC
Created attachment 5153 [details]
patch for sw/util/makefile.mk
Comment 18 Martin Hollmichel 2003-03-26 07:37:50 UTC
mh->georgez: I gave you commit access to the OOO_STABLE_1 branch.
please commit by yourself.
Comment 19 Unknown 2003-04-01 04:21:54 UTC
Thanks Martin.

George
Comment 20 Unknown 2003-04-08 02:00:16 UTC
accepting issue
Comment 21 Unknown 2003-04-08 02:02:17 UTC
If this cant make it inot 1.0.3, then 1.0.4 is also acceptable.

George
Comment 22 Unknown 2003-04-14 06:35:55 UTC
retargeting to 1.0.4
Comment 23 Unknown 2003-04-14 07:19:59 UTC
tried commiting this, but got:
cvs [server aborted]: "commit" requires write access to the repository
cvs commit: saving log message in /tmp/cvsBAAa1Z5HT

Is the STABLE_1 branch locked?
Comment 24 Unknown 2003-06-16 05:16:40 UTC
re-assigning to Nick Blievers
Comment 25 nickb 2003-07-07 04:23:41 UTC
Accepting
Comment 26 utomo99 2003-10-29 03:57:46 UTC
Hello, 

I found that this Issue is targetted to 1.0.4. 
Can you please retargetting this issue since 1.0.4 is not planned.
maybe to 1.1.1 ? 

and can you remove the keyword, since you already accept it ? 

Thanks
Comment 27 nickb 2003-10-29 06:11:48 UTC
Changed milestone
Comment 28 pavel 2003-12-23 18:41:30 UTC
No one seems to be actively working on IRIX port thus retargeting to 1.1.2.
Comment 29 Martin Hollmichel 2004-04-23 17:34:35 UTC
No one seems to be actively working on IRIX port thus retargeting to 1.1.3.
Comment 30 pavel 2004-08-18 21:59:51 UTC
No one seems to be actively working on IRIX port thus retargeting to OOoPleaseHelp.
Comment 31 caolanm 2010-03-29 21:12:02 UTC
per issue 106845 sb removed the partial irix port, so this doesn't make sense in
isolation anymore
Comment 32 caolanm 2010-03-29 21:12:20 UTC
closing