Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
Summary: | IRIX: setup2/source/agenda/agenda.cxx SiMakeDirAction accepts ByteString not String? | ||
---|---|---|---|
Product: | porting | Reporter: | nickb |
Component: | code | Assignee: | sander_traveling |
Status: | CLOSED FIXED | QA Contact: | issues@porting <issues> |
Severity: | Trivial | ||
Priority: | P3 | CC: | issues |
Version: | OOo 1.1 RC | ||
Target Milestone: | OOo 1.1.1 | ||
Hardware: | SGI | ||
OS: | IRIX | ||
Issue Type: | DEFECT | Latest Confirmation in: | --- |
Developer Difficulty: | --- | ||
Issue Depends on: | |||
Issue Blocks: | 809 |
Description
nickb
2003-07-31 06:47:06 UTC
Hmmm, I changed ByteString temp = aLogfile.GetPath().GetFull(); To ByteString temp = aLogfile.GetFull(); As the double function call seemed superfluous. This is possibly wrong, but I'm tired, and its compiling again. Hmm in setup2/source/agenda/environ.cxx if ( anAppFileName.Len() ) { SiDirEntry temp = anAppEntry.GetPath(); m_aStartPath = temp.GetFull(); } else This seems a much cleaner solution. Will change agenda.cxx to: if( !aLogfile.GetPath().Exists() ) { //SiMakeDirAction aMkDir( this, (const SiDirEntry&)(aLogfile.GetPath()).GetFull() ); SiDirEntry temp = aLogfile.GetPath(); SiMakeDirAction aMkDir( this, temp.GetFull()); aMkDir.Execute( *m_pEnv ); } setup2/source/agenda/install.cxx has the same thing. setup2/source/agenda/installu.cxx setup2/source/ui/main.cxx setup2/source/ui/magenda.cxx setup2/source/ui/mainevt.cxx setup2/source/basic/wrapper.cxx too scptools/source/linker/scppkg.cxx set target milestone to 1.1.1 fix commited in ooo111fix1 installation/ setup2/ source/ ui/ main.cxx is not compilable: /home/oo//BuildDir/ccache /opt/experimental/bin/g++ -fmessage-length=0 -c -I. -I. -I../inc -I../../inc -I../../unx/inc -I../../unxlngi4.pro/inc -I. -I/home/oo/BuildDir/ooo_1.1.0_src/solver/645/unxlngi4.pro/inc/stl -I/home/oo/BuildDir/ooo_1.1.0_src/solver/645/unxlngi4.pro/inc/external -I/home/oo/BuildDir/ooo_1.1.0_src/solver/645/unxlngi4.pro/inc -I/home/oo/BuildDir/ooo_1.1.0_src/solenv/unxlngi4/inc -I/home/oo/BuildDir/ooo_1.1.0_src/solenv/inc -I/home/oo/BuildDir/ooo_1.1.0_src/res -I/home/oo/BuildDir/ooo_1.1.0_src/solver/645/unxlngi4.pro/inc/stl -I/home/oo/BuildDir/ooo_1.1.0_src/solenv/inc/Xp31 -I/usr/lib/java/include -I/usr/lib/java/include/linux -I/usr/lib/java/include/native_threads/include -I/usr/X11R6/include -I. -I../../res -I. -O1 -pipe -mcpu=pentiumpro -fno-for-scope -fpermissive -fno-rtti -include preinclude.h -fexceptions -fno-enforce-eh-specs -DLINUX -DUNX -DVCL -DGCC -DC300 -DINTEL -DCVER=C300 -D_USE_NAMESPACE -DGLIBC=2 -DX86 -D_PTHREADS -D_REENTRANT -DNEW_SOLAR -D_USE_NAMESPACE=1 -DSTLPORT_VERSION=400 -D__DMAKE -DUNIX -DCPPU_ENV=gcc3 -DSUPD=645 -DBUILD=8693 -DPRODUCT -DNDEBUG -DPRODUCT_FULL -DOSL_DEBUG_LEVEL=0 -DOPTIMIZE -DEXCEPTIONS_ON -DCUI -DSOLAR_JAVA -DSRX645 -DMULTITHREAD -o ../../unxlngi4.pro/obj/main.o /home/oo/BuildDir/ooo_1.1.0_src/setup2/source/ui/main.cxx In file included from /home/oo/BuildDir/ooo_1.1.0_src/setup2/source/ui/mainwnd.hxx:77, from /home/oo/BuildDir/ooo_1.1.0_src/setup2/source/ui/main.cxx:144: ../../inc/stpwatch.hxx:88:8: warning: extra tokens at end of #endif directive /home/oo/BuildDir/ooo_1.1.0_src/setup2/source/ui/main.cxx: In member function `BOOL SetupApp::FindAndReadScript()': /home/oo/BuildDir/ooo_1.1.0_src/setup2/source/ui/main.cxx:1659: no matching function for call to `SiEnvironment::SetDestPath(DirEntry)' ../../inc/environ.hxx:553: candidates are: void SiEnvironment::SetDestPath(const ByteString&) /home/oo/BuildDir/ooo_1.1.0_src/setup2/source/ui/main.cxx:1659: parse error before `)' token /home/oo/BuildDir/ooo_1.1.0_src/setup2/source/ui/main.cxx:1680: conversion from `<unknown type>' to non-scalar type `SiDirEntry' requested dmake: Error code 1, while making '../../unxlngi4.pro/obj/main.obj' reassign to Sander. How silly of me - I made temp be teh result of the GetPath() butthen forgot to take the GetPath() out and so had temp.GetPath().GetFull() close issue |