Issue 16607

Summary: 11rc: sal patches for locale + interlock
Product: porting Reporter: fa <dan>
Component: codeAssignee: fa <dan>
Status: CLOSED FIXED QA Contact: issues@porting <issues>
Severity: Trivial    
Priority: P3 CC: ed, issues, khendricks
Version: OOo 1.1 RC   
Target Milestone: OOo 1.1 RC   
Hardware: Mac   
OS: Mac OS X, all   
Issue Type: PATCH Latest Confirmation in: ---
Developer Difficulty: ---
Issue Depends on:    
Issue Blocks: 16413    
Attachments:
Description Flags
cd to sal, patch -p0 < /path/to/patchfile Adds PORTS locale detection and preliminary interlock code for gcc 3.3
none
unzip to sal/systools, implements OS X shared library for locale lookup
none
cd sal, patch -p0 < /path/to/patchfile SUPERCEDES all previous sal.xxx.11rc patches, updates interlock code
none
contains only interlock asm pieces of 070903-2 patch
none
contains all other non-interlock pieces of 070903-2 patch none

Description fa 2003-07-09 14:36:59 UTC
These patches add in sal locale support for Mac OS X.  Also update interlock code for gcc 3.3 
(suggestions from Jim White), but I'd really like someone to look over this as I'm unsure about it.  
kevin?
Comment 1 fa 2003-07-09 14:39:53 UTC
Created attachment 7500 [details]
cd to sal, patch -p0 < /path/to/patchfile   Adds PORTS locale detection and preliminary interlock code for gcc 3.3
Comment 2 fa 2003-07-09 14:41:28 UTC
Created attachment 7501 [details]
unzip to sal/systools, implements OS X shared library for locale lookup
Comment 3 fa 2003-07-09 16:08:46 UTC
Created attachment 7506 [details]
cd sal, patch -p0 < /path/to/patchfile  SUPERCEDES all previous sal.xxx.11rc patches, updates interlock code
Comment 4 khendricks 2003-07-10 15:41:32 UTC
Hi Dan,

This patch looks fine but it is complicated enough I will apply it
to my PPC Linux sal from OOo 1.1rc and verify that it does not 
break anything for anyone else before approving it for commit.

Kevin
Comment 5 fa 2003-07-14 19:16:25 UTC
I will break this patch into two parts: the interlock asm stuff and everything else.  I 
will commit the everything else (including sal locale changes + extra OS X locale 
dylib) but NOT commit the interlock stuff pending your test Kevin.

Dan
Comment 6 fa 2003-07-14 19:19:48 UTC
Created attachment 7644 [details]
contains only interlock asm pieces of 070903-2 patch
Comment 7 fa 2003-07-14 19:20:55 UTC
Created attachment 7645 [details]
contains all other non-interlock pieces of 070903-2 patch
Comment 8 khendricks 2003-07-14 19:30:14 UTC
Hi Dan,

Please commit the whole thing.

I can handle the asm interlock stuff just fine for PPC Linux.

No worries.

Kevin
Comment 9 fa 2003-07-14 19:32:44 UTC
Changes from sal.070903-2-locale.11rc.patch committed to cws_srx645_ooo11rc2.
Comment 10 fa 2003-07-14 19:34:15 UTC
sal.070903-2-interlock.11rc.patch committed to cws_srx645_ooo11rc2
Comment 11 Martin Hollmichel 2004-02-15 07:28:38 UTC
verfied in 1.1.0.
Comment 12 Martin Hollmichel 2004-02-15 07:31:48 UTC
close issue