Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
Summary: | 11rc: soltools patch - checkdll -> NSModule, makedepend fstat() issue | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | porting | Reporter: | fa <dan> | ||||||
Component: | code | Assignee: | fa <dan> | ||||||
Status: | CLOSED FIXED | QA Contact: | issues@porting <issues> | ||||||
Severity: | Trivial | ||||||||
Priority: | P3 | CC: | ed, issues, khendricks | ||||||
Version: | OOo 1.1 RC | ||||||||
Target Milestone: | OOo 1.1 RC | ||||||||
Hardware: | Mac | ||||||||
OS: | Mac OS X, all | ||||||||
Issue Type: | PATCH | Latest Confirmation in: | --- | ||||||
Developer Difficulty: | --- | ||||||||
Issue Depends on: | |||||||||
Issue Blocks: | 16413 | ||||||||
Attachments: |
|
Description
fa
2003-07-03 20:49:12 UTC
Created attachment 7393 [details]
cd to soltools, patch -p0 < /path/to/patchfile Updates checkdll to use NSModule APIs, work around soltools fstat() wierdness
set target milestone Hi Dan, SAince this touches non-MacOSX specific code (the fstat stuff), I will test it on my PPC Linux build to make sure all is okay (with your change, you are assigning a 64 bit quantity to a 32 bit type here?). Kevin the 64 bit vs 32 bit issue was covered in porting@ - both freebsd and macosx (*bsd in general - and possibly os-s like solaris with some defines turned on) can access fiels upto 2^64, while memory may remain 32bit meaning that if there ever is a case where a file taht doesn't fit in memory would be loaded, mkdepend should just error out instead of mangling things in various ways. Created attachment 7662 [details]
Correct variable types to prevent overflows
Hi Dan, I reviewed it and I think you have handled all of Joerg's issues since you now use a signed type to hold the rerutn value from read and you even test for truncation. This looks good to me so approved. Kevin same here - it looks ok committed to cws_srx645_ooo11rc2 verfied in 1.1.0. close issue |