Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
Summary: | addresstemplate(.cxx and .hxx) have wrong include definitions | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | utilities | Reporter: | bluedwarf <bluedwarf> | ||||||
Component: | code | Assignee: | Frank Schönheit <frank.schoenheit> | ||||||
Status: | CLOSED NOT_AN_OOO_ISSUE | QA Contact: | Unknown <non-migrated> | ||||||
Severity: | Trivial | ||||||||
Priority: | P3 | CC: | issues | ||||||
Version: | OOo 1.1 Beta | ||||||||
Target Milestone: | --- | ||||||||
Hardware: | PC | ||||||||
OS: | All | ||||||||
Issue Type: | PATCH | Latest Confirmation in: | --- | ||||||
Developer Difficulty: | --- | ||||||||
Attachments: |
|
Description
bluedwarf
2003-04-03 22:41:25 UTC
Created attachment 5447 [details]
patch for addresstemplate.hxx(rev 1.4) to solve the wrong include definition
Created attachment 5448 [details]
patch for addresstemplate.cxx(rev 1.16) to solve the wrong include definition
I have signed JCA, it is no problem to merge this patch to OpenOffice.org and StarOffice source code. Best Regareds, @fs: Seems to be your stuff. Takashi, I suppose your build did something wrong. If you look at vcl/prj/d.lst, respectively comphelper/prj/d.lst, you see that the both files in question are explicitly delivered to _two_ locations. Means, when doing a deliver in comphelper, then comphelper/inc/comphelper/extract.hxx is delivered to _both_ comphelper/extract.hxx _and_ cppuhelper/extract.hxx Similar situation for vcl/inc/button.hxx, which is delivered to both vcl/button.hxx and vcl/imagebtn.hxx. This is for historical reasons: the respective include files were moved/renamed in the past, and to not adjust all client code, this was solved by adjusting the "d.lst" files which were used for delivering. So at the moment, I am somehwat unsteady regarding your patches: Though they won't hurt, they are not necessary, instead, I really assume you have a problem in your build setup. Can you please check this first? (finally, if this would not be a build problem, this would imply that all builds on all other platforms would break there, too, which simply isn't the case :) - this code has compiled for ages on all platforms ...) any update on this? no feedback since more than 3 months -> resolving INVALID. Feel free to reopen if the problem still strikes you. closing |