Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
Summary: | Correct some warnings in the xml code. Note that this corrects an error | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | xml | Reporter: | foskey | ||||||
Component: | definition | Assignee: | mikhail.voytenko | ||||||
Status: | CLOSED FIXED | QA Contact: | issues@xml <issues> | ||||||
Severity: | Trivial | ||||||||
Priority: | P4 | CC: | issues | ||||||
Version: | 644 | ||||||||
Target Milestone: | OOo 1.1 Beta2 | ||||||||
Hardware: | PC | ||||||||
OS: | All | ||||||||
Issue Type: | PATCH | Latest Confirmation in: | --- | ||||||
Developer Difficulty: | --- | ||||||||
Attachments: |
|
Description
foskey
2003-02-23 01:53:27 UTC
Created attachment 4853 [details]
patch file for sax - correct processing for utf-16
in package/source/zipapi/ZipFile.cxx: There is a warning about always being false: if ( nTotal > ZIP_MAXENTRIES ) The definition is: sal_Int32 ZipFile::readCEN() throw(IOException, ZipException, RuntimeException) { sal_Int32 nCenLen, nCenPos = -1, nCenOff, nEndPos, nLocPos; sal_Int16 nCount, nTotal; And it is retreived from: aGrabber >> nTotal; It is possible that nTotal should be 32 bits not 16 or unsigned 16. I cannot judge this. Identifying problem to owner. Created attachment 4855 [details]
simple clean up of warnings, incomplete.
. Sascha, can you please have a look at this bug and send it to MAV afterwards. ok, I take it. Hi Mikhail, I took the fix to solve the problem in xml2utf.cxx. Please have a look on the fix of the zip package. Thanks Sascha . The package is fixed. Indeed, the unsigned 16-bit value should be used. talked to SAB and MAV and got the Go from them. So I set it to verified. Frank . |