Issue 6780

Summary:

Dialog popup when loading malformed sxd files.

Product:

App Dev

Reporter:

Unknown <non-migrated>

Component:

api

Assignee:

thorsten.martens

Status:

CLOSED FIXED

QA Contact:

issues@api <issues>

Severity:

Trivial

Priority:

CC:

issues

Version:

3.3.0 or older (OOo)

Target Milestone:

---

Hardware:

Sun

OS:

SunOS

Issue Type:

DEFECT

Latest Confirmation in:

---

Developer Difficulty:

---

Attachments:

Description	Flags
can be used for testing	none

Description Unknown 2002-08-06 10:06:09 UTC

When I'm loading a malformed sxd document from the java ODK api,
I get a popup dialog saying.

-------------8<--------------------------------------------------------------
Error loading document file:////tmp/OOConverterTestFiles/TestDocumentBad.sxd:
Read-Error.
Format error discovered in the sub-document content.xml at position
2,217(row,col).
OOFel.txt (END)
------------>8---------------------------------------------------------------

The document is malformed by me, I have deleted some random parts in it.
My testfile is available at:
http://www-und.ida.liu.se/~clamu955/TestDocumentBad.sxd

Comment 1 ooo 2002-12-19 10:40:45 UTC

implementation issue

Comment 2 Mathias_Bauer 2003-01-08 14:40:42 UTC

Code that is called while a document is loaded or saved should never 
show any dialogs. Only an interaction handler is allowed to do so.

Unfortunately  the SfxLoadEnvironment_Impl shows ErrorMessages if an 
error code is set at the SfxObjectShell.

So we should do the following:

Create a new "general" exception/interaction that just transports an 
error code.

If the error code is a "warning":
check medium for interaction handler and use it, if there is none, 
ignore the error code, set error code to ERRCODE_NONE.

If the error code is an "error":
check medium for interaction handler and use it, if there is none, 
throw an exception, set error code to ERRCODE_ABORT.
Little problem: throwing the exception is only possible inside the 
Frameloader, not in LoadEnvironment_Impl!

Comment 3 Mathias_Bauer 2003-01-08 14:58:06 UTC

Comment 4 andreas.schluens 2003-01-15 05:37:20 UTC

Comment 5 andreas.schluens 2003-01-20 14:10:04 UTC

I`ve created a new interaction for such generic core errors/warnings
und integrated it into the framework/sfx modules. Now such errors/
warnings can be suppressed via api.

Comment 6 andreas.schluens 2003-01-20 14:11:06 UTC

Created attachment 4374 [details]
can be used for testing

Comment 7 andreas.schluens 2003-01-24 12:33:38 UTC

I've forgot ...
the attached test script needs one damaged XML file. It can be created
very easy. Save any content as office 6.0 xml format - rename the file
to *.zip - unpack it - change the content.xml part by removing one xml
end tag - pack the zip again and rename it back.

Comment 8 andreas.schluens 2003-01-24 12:42:12 UTC

Please check it on \\mav-11198\CWS\as3. THX

Comment 9 andreas.schluens 2003-01-24 12:44:17 UTC

Comment 10 thorsten.martens 2003-01-30 09:56:42 UTC

Issue has been verified in cws as3 -> OK !

Comment 11 thorsten.martens 2003-01-30 09:58:13 UTC

Comment 12 michael.bemmer 2003-03-13 11:09:58 UTC

As mentioned on the qa dev list on March 5th I will close all resolved
<wontfix/duplicate/worksforme/invalid> issues. Please see this posting for details.