Issue 16193

Summary: missing dlclose() in setup2/*/loader.c, glibc version parse fix
Product: Installation Reporter: holgerth <holger_thon>
Component: codeAssignee: Olaf Felka <olaf-openoffice>
Status: CLOSED FIXED QA Contact: issues@installation <issues>
Severity: Trivial    
Priority: P3 CC: issues
Version: OOo 1.1 RC   
Target Milestone: OOo 1.1 RC   
Hardware: Other   
OS: Linux, all   
Issue Type: PATCH Latest Confirmation in: ---
Developer Difficulty: ---
Attachments:
Description Flags
loader.c.patch none

Description holgerth 2003-06-28 17:12:38 UTC
1. In void check_glibc(), dlclose() is missing  
2. glibc version parsing is string based. 
 
Last will fail, if a 2 digit major or minor release of glibc would come out; i.e. 
strncmp("2.2", "2.10", 3) or strncmp("2.2", "10.0", 3) would not do the job. 
 
Attached patch fixes those problems
Comment 1 holgerth 2003-06-28 17:13:20 UTC
Created attachment 7209 [details]
loader.c.patch
Comment 2 Olaf Felka 2003-06-30 08:56:39 UTC
Hi Dirk,
please have a look at this patch.
Comment 3 dirk.voelzke 2003-07-01 15:01:06 UTC
I'll have a look.
Comment 4 dirk.voelzke 2003-07-02 10:00:41 UTC
fixed in cws setup15
Comment 5 dirk.voelzke 2003-07-04 11:28:42 UTC
Please verify.
Comment 6 Olaf Felka 2003-07-04 12:26:38 UTC
As far as I can see it's ok.
Comment 7 Olaf Felka 2003-07-04 12:26:53 UTC
Verified.
Comment 8 Olaf Felka 2003-07-15 12:24:06 UTC
integrated