|
Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
| Summary: | return type mismatch - return by value assigned to reference | ||
|---|---|---|---|
| Product: | Writer | Reporter: | khendricks |
| Component: | code | Assignee: | foskey |
| Status: | CLOSED FIXED | QA Contact: | issues@sw <issues> |
| Severity: | Trivial | ||
| Priority: | P1 (highest) | CC: | issues |
| Version: | OOo 1.1 Beta2 | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| Issue Type: | DEFECT | Latest Confirmation in: | --- |
| Developer Difficulty: | --- | ||
| Issue Depends on: | |||
| Issue Blocks: | 13400 | ||
reassigned and re set prio reassigned Fixed in CWS sw015. Files changed register.cxx 1.5.22.1 . TL->Kevin: Please have a look... . The Following lines of code must be changed to remove the SAL_ISO_CONST. This is a temporary hack. ./sw/source/ui/uno/SwXDocumentSettings.cxx: SAL_ISO_CONST SwDBData& rData = mpDoc->GetDBData(); ./sw/source/ui/uno/SwXDocumentSettings.cxx: SAL_ISO_CONST SwDBData& rData = mpDoc->GetDBData(); ./sw/source/ui/uno/SwXDocumentSettings.cxx: SAL_ISO_CONST SwDBData& rData = mpDoc->GetDBData(); Hi Re-assigneing this to Ken so that he can commit the fix and test it since he is using gcc 3.3 for his builds. Thanks, Kevin These occurrence have been removed. Closing issue. Use "close" if you want to close this fully. Closing |
cc 3.3 now provides error messages when there are return type mismatches such as when a method returns an object by value that is assigned to a reference which is a bug since the reference points to a temporary variable created to hold the return by value. An occurrence of this type occurred here see ... (fixme?) Please evaluate that line and fix the code in question to prevent the bug if needed. starmath/source/register.cxx @@ -154,7 RTL_CONSTASCII_USTRINGPARAM("/") ) + SmXMLImport_getImplementationName() + ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM( "/UNO/SERVICES") ) ); (fixme?)::com::sun::star::uno::Sequence< rtl::OUString > &rServices = SmXMLImport_getSupportedServiceNames(); for(i = 0; i < rServices.getLength(); i++ ) xNewKey->createKey( rServices.getConstArray()[i]);