Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
Summary: | Remove 5400 warnings for MSVC | ||||||
---|---|---|---|---|---|---|---|
Product: | porting | Reporter: | quetschke | ||||
Component: | code | Assignee: | quetschke | ||||
Status: | CLOSED FIXED | QA Contact: | issues@porting <issues> | ||||
Severity: | Trivial | ||||||
Priority: | P3 | CC: | issues | ||||
Version: | 644 | ||||||
Target Milestone: | OOo 1.1 Beta2 | ||||||
Hardware: | PC | ||||||
OS: | Windows 2000 | ||||||
Issue Type: | DEFECT | Latest Confirmation in: | --- | ||||
Developer Difficulty: | --- | ||||||
Attachments: |
|
Description
quetschke
2003-04-06 11:13:48 UTC
Created attachment 5484 [details]
Patch for sal/inc/rtl/ustring.hxx
Oops, s/define/#define/g mh->sb: please review ! This has already been fixed, not by massaging ("uglyfying") the source code, but rather by turning this specific MSVC warning off. We had a discussion about it (I think it was only inhouse), and agreed that this warning is rather useless (it should be obvious that, in general, changing from one representation---in this case sal_Bool resp. char---to another---in this case bool---requires some sort of conversion; no warning should be given here---there isn't any warning in other cases, either, like changing from long to short or from int to float). Fixed as part of internal bug #107762# (child workspace uno1, integrated in SRX644M7S2), see sal/inc/sal/config.h 1.15.40.1. reassigned Resolved. c |